Skip to content

Add extract(quarter/dow/doy) support #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 5 commits into from
Aug 19, 2023
Merged

Add extract(quarter/dow/doy) support #11388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b4aae6
Add extract(quarter) support
Aug 19, 2023
2ccbe2d
Add dow
Aug 19, 2023
9583676
Add DOY
Aug 19, 2023
23fb7f3
Add tests
xiangfu0 Aug 19, 2023
6e0d9a5
Minor change of Field order to be easier to track
Jackie-Jiang Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class ExtractTransformFunction extends BaseTransformFunction {
protected Chronology _chronology = ISOChronology.getInstanceUTC();

private enum Field {
YEAR, MONTH, DAY, HOUR, MINUTE, SECOND
YEAR, QUARTER, MONTH, DAY, DOY, DOW, HOUR, MINUTE, SECOND
}

@Override
Expand Down Expand Up @@ -76,6 +76,10 @@ private void convert(long[] timestamps, int numDocs, int[] output) {
accessor = _chronology.year();
output[i] = accessor.get(timestamps[i]);
break;
case QUARTER:
accessor = _chronology.monthOfYear();
output[i] = (accessor.get(timestamps[i]) - 1) / 3 + 1;
break;
case MONTH:
accessor = _chronology.monthOfYear();
output[i] = accessor.get(timestamps[i]);
Expand All @@ -84,6 +88,14 @@ private void convert(long[] timestamps, int numDocs, int[] output) {
accessor = _chronology.dayOfMonth();
output[i] = accessor.get(timestamps[i]);
break;
case DOY:
accessor = _chronology.dayOfYear();
output[i] = accessor.get(timestamps[i]);
break;
case DOW:
accessor = _chronology.dayOfWeek();
output[i] = accessor.get(timestamps[i]);
break;
case HOUR:
accessor = _chronology.hourOfDay();
output[i] = accessor.get(timestamps[i]);
Expand Down
11 changes: 10 additions & 1 deletion ...egration-tests/src/test/java/org/apache/pinot/integration/tests/custom/TimestampTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ public void testTimeExtractFunction(boolean useMultiStageQueryEngine)
+ "WEEK_OF_YEAR(ts1), WEEK_OF_YEAR(ts2),\n"
+ "DAY_OF_YEAR(ts1), DAY_OF_YEAR(ts2),\n"
+ "DAY_OF_MONTH(ts1), DAY_OF_MONTH(ts2),\n"
+ "DAY_OF_WEEK(ts1), DAY_OF_WEEK(ts2)\n"
+ "DAY_OF_WEEK(ts1), DAY_OF_WEEK(ts2),\n"
+ "DOY(ts1), DOY(ts2),\n"
+ "DOW(ts1), DOW(ts2),\n"
+ "QUARTER(ts1), QUARTER(ts2)\n"
+ "FROM %s\n"
+ "LIMIT %d\n", getTableName(), getCountStarResult());
JsonNode jsonNode = postQuery(query);
Expand All @@ -165,6 +168,12 @@ public void testTimeExtractFunction(boolean useMultiStageQueryEngine)
jsonNode.get("resultTable").get("rows").get(i).get(19).asInt());
assertEquals(jsonNode.get("resultTable").get("rows").get(i).get(20).asInt(),
jsonNode.get("resultTable").get("rows").get(i).get(21).asInt());
assertEquals(jsonNode.get("resultTable").get("rows").get(i).get(22).asInt(),
jsonNode.get("resultTable").get("rows").get(i).get(23).asInt());
assertEquals(jsonNode.get("resultTable").get("rows").get(i).get(24).asInt(),
jsonNode.get("resultTable").get("rows").get(i).get(25).asInt());
assertEquals(jsonNode.get("resultTable").get("rows").get(i).get(26).asInt(),
jsonNode.get("resultTable").get("rows").get(i).get(27).asInt());
}
}

Expand Down