Skip to content

separate tags with commas as indicated in action doc#11303

Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom
gortiz:fix-codecov
Aug 11, 2023
Merged

separate tags with commas as indicated in action doc#11303
Jackie-Jiang merged 2 commits intoapache:masterfrom
gortiz:fix-codecov

Conversation

@gortiz
Copy link
Contributor

@gortiz gortiz commented Aug 9, 2023

@erichgess found that #10528 broke the codecov coverate.

There were two issues:

  • Metadata was wrong. Instead of separating tags, it created huge tags that concatenated all properties. That is being fixed as indicated in https://github.com/codecov/codecov-action (tags should be separated by commas).
  • Jacoco wasn't actually added to surefire because $argLine expression indicates that argLine should be eagerly evaluated before applying previous plugins. By changing that to @argLine, it can be evaluated after jacoco plugin modifies the property, as explained in the official doc.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #11303 (59c5096) into master (6fa4268) will increase coverage by 67.85%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11303       +/-   ##
=============================================
+ Coverage      0.11%   67.96%   +67.85%     
- Complexity        0     6508     +6508     
=============================================
  Files          2231     2231               
  Lines        120139   120152       +13     
  Branches      18218    18218               
=============================================
+ Hits            137    81662    +81525     
+ Misses       119982    32663    -87319     
- Partials         20     5827     +5807     
Flag Coverage Δ
integration1 20.77% <ø> (?)
integration1temurin11 ?
integration1temurin17 ?
integration1temurin20 ?
integration2 25.45% <ø> (?)
integration2temurin11 ?
integration2temurin17 ?
integration2temurin20 ?
java-11 14.41% <ø> (?)
java-17 65.53% <ø> (?)
java-20 33.63% <ø> (?)
temurin 67.96% <ø> (?)
unittests1 66.85% <ø> (?)
unittests1temurin11 ?
unittests1temurin17 ?
unittests1temurin20 ?
unittests2 14.41% <ø> (?)
unittests2temurin11 ?
unittests2temurin17 ?
unittests2temurin20 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1932 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 93a5a7e into apache:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants