separate tags with commas as indicated in action doc#11303
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Aug 11, 2023
Merged
separate tags with commas as indicated in action doc#11303Jackie-Jiang merged 2 commits intoapache:masterfrom
Jackie-Jiang merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11303 +/- ##
=============================================
+ Coverage 0.11% 67.96% +67.85%
- Complexity 0 6508 +6508
=============================================
Files 2231 2231
Lines 120139 120152 +13
Branches 18218 18218
=============================================
+ Hits 137 81662 +81525
+ Misses 119982 32663 -87319
- Partials 20 5827 +5807
Flags with carried forward coverage won't be shown. Click here to find out more. see 1932 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@erichgess found that #10528 broke the codecov coverate.
There were two issues:
$argLineexpression indicates thatargLineshould be eagerly evaluated before applying previous plugins. By changing that to@argLine, it can be evaluated after jacoco plugin modifies the property, as explained in the official doc.