HDDs-14195. [DiskBalancer] Improve DiskBalancer CLI Output Readability and Usability#9712
Open
Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Open
HDDs-14195. [DiskBalancer] Improve DiskBalancer CLI Output Readability and Usability#9712Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@ChenSammi Please review the PR. I have closed the last PR and opened a fresh one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are few issues with usability and readability of diskbalancer cli output:
Firstly, used set instead of list to store dnHostName for cli output so that it doesn't display duplicate hostnames if user give any diskbalancer command for same hostname twice like below:
Secondly, Instead of showing ip-address in json cli output show both ipaddress and dnHostName for better clarity.
bash-5.1$ ozone admin datanode diskbalancer stop --in-service-datanodes --json
[ {
"datanode" : "ozone-datanode-1 (172.18.0.5:19864)",
"action" : "stop",
"status" : "success"
}, {
"datanode" : "ozone-datanode-2 (172.18.0.9:19864)",
"action" : "stop",
"status" : "success"
}, {
"datanode" : "ozone-datanode-3 (172.18.0.10:19864)",
"action" : "stop",
"status" : "success"
}]
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14195
How was this patch tested?
Updated exisitng test cases.
Manually tested on docker cluster: