HDDS-14195. Do not send DiskBalancer start command to DN with active run#9527
Closed
Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Closed
HDDS-14195. Do not send DiskBalancer start command to DN with active run#9527Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Gargi-jais11 wants to merge 5 commits intoapache:masterfrom
Conversation
added 5 commits
December 18, 2025 15:13
ChenSammi
reviewed
Jan 23, 2026
| Map<String, Object> configMap = getConfigurationMap(); | ||
| if (configMap != null && !configMap.isEmpty()) { | ||
| result.put("configuration", configMap); | ||
| if (status.getRunningStatus() == DiskBalancerRunningStatus.RUNNING || |
Contributor
There was a problem hiding this comment.
Please do not do the filtering.
It's ok to send the start command again to a DN which has disk balancer running, and doesn't response with "*** is already running". It's called API idempotent.
Further more, filter DN at client side is inaccurate. There is chance that DN changes to STOPPED state after return the status.
Contributor
Author
|
Closing this PR, will open a new one as it is a kind of messed up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are few issues with usability and readability of diskbalancer cli output:
Firstly, used set instead of list to store dnHostName for cli output so that it doesn't display duplicate hostnames if user give any diskbalancer command for same hostname twice like below:
Secondly, Instead of showing ip-address in json cli output show dnHostName for better clarity.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14195
How was this patch tested?
Added new test cases to
TestDiskBalancerProtocolServerand updateTestDiskBalancerSubCommands,TestDiskBalancer.Tested locally: