Skip to content

Add support for Swift 5.4 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Conversation

Luke-Roy-IBM
Copy link
Member

Added suport for Swift 5.4 by copying and adapting core of Swift 5.3.
Files Modified in the core during this Process (version set to 5.4 from 5.3):

  • core/swift54Action/build.gradle
  • core/swift54Action/CHANGELOG.md
  • core/swift54Action/Dockerfile

Added Swift 5.4 entries to:

  • settings.gradle
  • .travis.yml
  • README.md
  • ansible/files/runtimes.json

@Luke-Roy-IBM Luke-Roy-IBM force-pushed the swift-5.4 branch 3 times, most recently from 77c7e98 to e8426cc Compare June 17, 2021 11:29
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick comment; otherwise lgtm. Thanks @Luke-Roy-IBM !

@dgrove-oss
Copy link
Member

@Luke-Roy-IBM - I took a quick look and didn't see your name listed as having filed a CLA; please correct me if I missed it. If you haven't done a CLA yet, please follow the instructions at https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md.

@Luke-Roy-IBM
Copy link
Member Author

@dgrove-oss Thank you for making me aware of the CLA I will get right on it.

@Luke-Roy-IBM Luke-Roy-IBM force-pushed the swift-5.4 branch 4 times, most recently from 31afd09 to ce48cd1 Compare June 22, 2021 11:18
- Added suport for Swift 5.4 by copying and adapting core of Swift 5.3. Files Modified during this Process (version set to 5.4 from 5.3):
-- core/swift54Action/build.gradle
-- core/swift54Action/CHANGELOG.md
-- core/swift54Action/Dockerfile
- Added Swift 5.4 entries to:
-- settings.gradle
-- .travis.yml
-- README.md
-- ansible/files/runtimes.json

Add missing EOL
add correct swift version to tests/dat/build.sh
add correct swift version to settings.gradle
Swift 5.3 runtime default set to false
add akka fix
@dgrove-oss
Copy link
Member

@Luke-Roy-IBM please rebase this on latest master to pick up the fixes from #139. Thanks

@dgrove-oss
Copy link
Member

Thanks for filing the CLA; I see Luke Roy listed in http://people.apache.org/unlistedclas.html now. As soon as we rebase and get a clean run from travis we can merge this.

@Luke-Roy-IBM
Copy link
Member Author

@dgrove-oss Thanks for the notice I have rebased my branch.

@dgrove-oss dgrove-oss merged commit 5dc532c into apache:master Jul 3, 2021
@rabbah
Copy link
Member

rabbah commented Jul 13, 2021

We're missing in this PR the scala tests for the 5.4 runtime.

Luke-Roy-IBM added a commit to Luke-Roy-IBM/openwhisk-runtime-swift that referenced this pull request Jul 14, 2021
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request apache#140
Luke-Roy-IBM added a commit to Luke-Roy-IBM/openwhisk-runtime-swift that referenced this pull request Jul 19, 2021
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request apache#140
rabbah pushed a commit that referenced this pull request Jul 19, 2021
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants