Skip to content

Fix build by adapting akka versions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2021
Merged

Fix build by adapting akka versions #139

merged 2 commits into from
Jul 2, 2021

Conversation

mhenke1
Copy link
Contributor

@mhenke1 mhenke1 commented Jun 14, 2021

dgrove-oss
dgrove-oss reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rabbah -- should we propagate this block across all the runtimes or does apache/openwhisk#5133 and https://github.com/apache/openwhisk/pull/5130/files simplify things?

@mhenke1 mhenke1 requested a review from rabbah June 14, 2021 15:36
@rabbah
Copy link
Member

rabbah commented Jun 14, 2021

Removing Mesos and bumping the akka kube management will reduce the change set to just 2 pinned libraries. Mesos was OK in Circle CI but the akka kube bump failed and I didn't investigate it. We can at least merge Mesos - I need to set aside some time to look into the other issue, I can't do it today.

@dgrove-oss
Copy link
Member

ok. I merged apache/openwhisk#5133. @mhenke1 I'll approve this in case it is urgently needed, but if we can stall for few days to avoid needing to do a separate PR to simplify later it might be better.

dgrove-oss
dgrove-oss approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in case fix is urgently needed; if possible would be nice to delay until we clean up the upstream to reduce the number of pinned libs

@mhenke1
Copy link
Contributor Author

mhenke1 commented Jun 15, 2021

@dgrove-oss I am fine with waiting some more days.
It would be great if the cleanup and the fixing of the runtimes build could be finished until end of month.

@mhenke1 mhenke1 mentioned this pull request Jun 21, 2021
Merged
@dgrove-oss dgrove-oss merged commit 6073686 into apache:master Jul 2, 2021
@dgrove-oss
Copy link
Member

Merged so we can unblock #140

@dgrove-oss dgrove-oss mentioned this pull request Jul 2, 2021
Merged
Luke-Roy-IBM added a commit to Luke-Roy-IBM/openwhisk-runtime-swift that referenced this pull request Jul 2, 2021
@Luke-Roy-IBM
Add fixes from apache#139
ca56259
dgrove-oss pushed a commit that referenced this pull request Jul 3, 2021
@Luke-Roy-IBM @mhenke1
Add support for Swift 5.4 (#140)
5dc532c 
* Add support for Swift 5.4
- Added suport for Swift 5.4 by copying and adapting core of Swift 5.3. Files Modified during this Process (version set to 5.4 from 5.3):
-- core/swift54Action/build.gradle
-- core/swift54Action/CHANGELOG.md
-- core/swift54Action/Dockerfile
- Added Swift 5.4 entries to:
-- settings.gradle
-- .travis.yml
-- README.md
-- ansible/files/runtimes.json

* Fix build by adapting akka versions (#139)
* Add fixes from #139

Co-authored-by: Martin Henke <martin.henke@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

@rabbah rabbah Awaiting requested review from rabbah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhenke1 @rabbah @dgrove-oss