-
Notifications
You must be signed in to change notification settings - Fork 648
fs cases: fix compile error #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kernel/fs/cases/fs_stream_test.c:279:70: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=] 279 | syslog(LOG_ERR, "len = %zi != return value from fwrite = %zi", | ~~^ | | | long int | %i 280 | len, ret); | ~~~ | | | int kernel/fs/cases/fs_stream_test.c:311:69: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=] 311 | syslog(LOG_ERR, "len = %zi != return value from fread = %zi", | ~~^ | | | long int | %i 312 | len, ret); | ~~~ | | | int Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. While it identifies a compile error, it provides no context about the change that caused the error or what was done to fix it. It also lacks critical information for reviewers. Here's why it's insufficient and what's missing:
Example of a better summary:
Example of a better impact assessment:
Example of basic testing information:
(Logs before showing the error, logs after showing successful compilation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Zhangshoukui :-)
Looks like GH detected conflict that needs to be resolved before merge? :-)
@Zhangshoukui please rebase the patch to fix the conflict. |
let's track this pr instead: #2905 |
Summary
Fix compile error:
Impact
buld
Testing
pass ci