Skip to content

test:add mutex socket syscall directory #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

txy-21
Copy link
Contributor

@txy-21 txy-21 commented Dec 17, 2024

Summary

  • Added socket, syscall, and mutex tests to testing/testsuites.
  • Some test cases have been added that cover the functionality of fs, mutex, pthread, socket, and syscall.
  • Code formatting fixes.

Impact

Testing / new test scenarios.

Testing

  • GH CI.
  • How did I perform local tests?

@cederom
Copy link
Contributor

cederom commented Dec 17, 2024

Thank you @txy-21, please update PR description it does not seem to match PR content..?

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Dec 17, 2024

Thank you @txy-21, please update PR description it does not seem to match PR content..?

Do you need update Make.defs and CMakelist.txt? @txy-21

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build errors :-(

@cederom
Copy link
Contributor

cederom commented Dec 18, 2024

Lets try the build :-)

@txy-21 txy-21 force-pushed the add-kernel-dir branch 2 times, most recently from 0f1d44a to 7f06fda Compare December 18, 2024 03:59
some test cases have been added that cover the functionality of fs, mutex, pthread, socket, and syscall

Signed-off-by: tengshuangshuang <tengshuangshuang@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 1e199e4 into apache:master Dec 18, 2024
25 checks passed
@lupyuen
Copy link
Member

lupyuen commented Dec 18, 2024

Sorry @txy-21 I think rv-virt:citest might be failing due to this PR, could you take a look? Thanks!
https://github.com/NuttX/nuttx/actions/runs/12390461445/job/34585612917#step:7:88

Configuration/Tool: rv-virt/citest
kernel/fs/cases/fs_fsync_test.c: In function 'test_nuttx_fs_fsync02':
Error: kernel/fs/cases/fs_fsync_test.c:140:20: error: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
  140 |   syslog(LOG_INFO, "the fbsize = %"PRIu64",buffer size=%d\n",
      |                    ^~~~~~~~~~~~~~~~
  141 |         statfsbuf.f_bsize, bufsize);
      |         ~~~~~~~~~~~~~~~~~
      |                  |
      |                  size_t {aka unsigned int}

BTW to test rv-virt:citest locally we could use Docker:
apache/nuttx#15170

sudo docker run \
  -it \
  --name nuttx \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/apache/nuttx
git clone https://github.com/txy-21/nuttx-apps \
  apps \
  --branch add-kernel-dir
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/risc-v-05.dat 

@cederom
Copy link
Contributor

cederom commented Dec 18, 2024

Thanks @lupyuen! Looks like fix is here #2900 just need a rebase due SPDX updates :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants