-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnodet
commented
May 23, 2024
•
edited
Loading
edited
- [MPLUGIN-508] Upgrade to 4.0.0-beta-3
Please hold this one off until #287 and 3.13.1 has been cut. I want to clean up first before we cut 3.x. |
gnodet
force-pushed
the
MPLUGIN-508
branch
2 times, most recently
from
May 27, 2024 18:29
de25cf4
to
c435c2e
Compare
gnodet
force-pushed
the
MPLUGIN-508
branch
2 times, most recently
from
May 30, 2024 11:38
e31a912
to
bfab846
Compare
michael-o
requested changes
May 30, 2024
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java
Show resolved
Hide resolved
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
Outdated
Show resolved
Hide resolved
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
Outdated
Show resolved
Hide resolved
gnodet
force-pushed
the
MPLUGIN-508
branch
2 times, most recently
from
May 30, 2024 17:39
44218a5
to
871da07
Compare
michael-o
reviewed
May 31, 2024
maven-plugin-plugin/src/it/skip/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
May 31, 2024
michael-o
reviewed
May 31, 2024
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
Show resolved
Hide resolved
michael-o
requested changes
May 31, 2024
maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no further objections, though two others should have a look as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.