[MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13

[gnodet]

JIRA issue: MPLUGIN-508

[hboutemy]

I don't understand the objective? what does "Upgrade to Maven 4.0.0-alpha-12" mean for this plugin that is for Maven 3?
can you elaborate, please?

[gnodet]

I don't understand the objective? what does "Upgrade to Maven 4.0.0-alpha-12" mean for this plugin that is for Maven 3? can you elaborate, please?

The plugin currently supports building either a Maven 3 or a Maven 4 plugin. Though I wonder if a streamlined would be better located inside Maven core...
It's used to build Maven 4 plugins with the PRs listed at apache/maven#1048

[hboutemy]

The plugin currently supports building either a Maven 3 or a Maven 4 plugin.

sorry, I still need some explanations because I can't guess from this PR touching 75 files described as "Upgrade to Maven 4.0.0-alpha-12"

is this PR about adding support for Maven 4 specific plugins in addition to classical Maven 3 plugins? or just upgrading such a support added before that I overlooked?

Is there a Maven 4 plugin IT to look at such a Maven 4 plugin?

and key question: is this PR intended for 3.12.0 release, as noted in Jira?

[gnodet]

The plugin currently supports building either a Maven 3 or a Maven 4 plugin.

sorry, I still need some explanations because I can't guess from this PR touching 75 files described as "Upgrade to Maven 4.0.0-alpha-12"

Most of the 75 files are just a renaming of the mavenVersion to maven3Version to make it more intuitive which one is used.

is this PR about adding support for Maven 4 specific plugins in addition to classical Maven 3 plugins? or just upgrading such a support added before that I overlooked?

The support was added quite some time ago (50482ba). This PR is just to upgrade to alpha-13 (and needs to be adjusted with the release)

Is there a Maven 4 plugin IT to look at such a Maven 4 plugin?

Yes, there's one at https://github.com/apache/maven-plugin-tools/tree/5297a91a8f8b4df54c96566b0629bb72944c2047/maven-plugin-plugin/src/it/v4api

and key question: is this PR intended for 3.12.0 release, as noted in Jira?

Yes

[gnodet]

The plugin currently supports building either a Maven 3 or a Maven 4 plugin.

sorry, I still need some explanations because I can't guess from this PR touching 75 files described as "Upgrade to Maven 4.0.0-alpha-12"

Most of the 75 files are just a renaming of the mavenVersion to maven3Version to make it more intuitive which one is used.

is this PR about adding support for Maven 4 specific plugins in addition to classical Maven 3 plugins? or just upgrading such a support added before that I overlooked?

The support was added quite some time ago (50482ba). This PR is just to upgrade to alpha-13 (and needs to be adjusted with the release)

Is there a Maven 4 plugin IT to look at such a Maven 4 plugin?

Yes, there's one at https://github.com/apache/maven-plugin-tools/tree/5297a91a8f8b4df54c96566b0629bb72944c2047/maven-plugin-plugin/src/it/v4api

and key question: is this PR intended for 3.12.0 release, as noted in Jira?

Yes

FWIW, I think the plugin supporting Maven 4 would be better located inside maven-core colocated with the API (and maybe soon the implementation extracted with apache/maven#1441). Same for the plugin-testing framework also contains support for both Maven 3 and Maven 4 in the same library, which is not really clean imho.

[hboutemy]

I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR
you'll need to rebase to get a more focused PR, that we'll be able to describe: from what I see, the upgrade adds some very new approach like DI that would be useful to describe

I'd like to do a release next week: we'll need to define if we can get this update in or not

[gnodet]

I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR you'll need to rebase to get a more focused PR, that we'll be able to describe: from what I see, the upgrade adds some very new approach like DI that would be useful to describe

I'd like to do a release next week: we'll need to define if we can get this update in or not

The support for 4.x plugins cannot really be finalised before the API is, given this target is moving. However, we need to keep up to date so that we can work on plugins more easily. I think the plugin could be trimmed down (just the actual plugin, we don't need other modules) and moved to maven-core to support v4 plugins...

[hboutemy]

too complex answer, I'm not sure what to do to release plugin-tools 3.12.0 this WE regarding this PR associated to MPLUGIN-508, currently marked as the only non-done issue for the release https://issues.apache.org/jira/projects/MPLUGIN/versions/12354176:

1. release now without the PR?
2. push to finalize to PR before releasing? (need to define the acceptance criteria)

[hboutemy]

IIUC, discussion means this PR is not ready for merge and release: I'll release 3.12.0 without

[slawekjaranowski]

should be a PR as draft

[gnodet]

Closed in favour of #286