Skip to content

Conversation

@hboutemy
Copy link
Member

@hboutemy hboutemy commented Feb 27, 2024

https://issues.apache.org/jira/browse/MJAR-289

still need to test (I did not check on a project that uses toolchains) and create IT

@hboutemy hboutemy marked this pull request as draft February 27, 2024 23:31
@slawekjaranowski
Copy link
Member

Similar task was done in codehaus-plexus/plexus-compiler#357
Maybe we can extract code to some of commons library

@hboutemy
Copy link
Member Author

hboutemy commented Mar 1, 2024

any idea where you'd put that, so it has a chance to be reused? I fear it is overkill given the size of the feature

and the real value we need is the integration in the jar creation process and testing it in different cases: with or without toolchain, perhaps other scenario that we'll add in the future if we find some shortcomings

@slawekjaranowski
Copy link
Member

I think that it not resolve MJAR-289, it resolve only one case described in MJAR-62
For MJAR-289 we need a changes in plexus-archiver

So I have created #73 based on it

@jira-importer
Copy link

Resolve #439

1 similar comment
@jira-importer
Copy link

Resolve #439

@hboutemy
Copy link
Member Author

I'm not clear if I really understood the report from MJAR-289, as it seems it is describing a run failure (based on a cause I still don't fully understand)

what is now clear to me is that @slawekjaranowski implemented what I was trying to do with this PR: this PR has been superceeded my #73

so closing this PR

@hboutemy hboutemy closed this Oct 11, 2025
@hboutemy hboutemy deleted the MJAR-289 branch October 11, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants