[MJAR-289] Support toolchain

[jira-importer]

b. ohnsorg opened MJAR-289 and commented

1. Configure a toolchain to use a more recent JDK, e.g. 17
2. run mvn clean install with a different (older) JDK, e.g. 11
3. maven-jar-plugin bails out with exit code other than 0 from jar command

 

It seems very likely (see MJAR-62) that this plugin doesn't support toolchains at all. Since packaging as JAR is a basic operation this has to work out of the box, when using toolchains.

 

Instead current version of maven-jar-plugin runs a jar command that does not create a JAR. Since compilation takes place based on toolchain class files are of format version 61. This is incompatible with the jar command from a JDK 11.

 

[…]
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (default-testCompile) @ jpianotrain-core ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/opt/jdk-17.0.2/]
[…]
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ jpianotrain-core ---
[INFO] Toolchain in maven-surefire-plugin: JDK[/opt/jdk-17.0.2/]

[…]
[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ jpianotrain-core ---
[INFO] Building jar: /home/onkobu/svn/jpianotrain/trunk/jpianotrain-core/target/jpianotrain-core-0.0.4-SNAPSHOT.jar
java.lang.module.InvalidModuleDescriptorException: Unsupported major.minor version 61.0
    at java.base/jdk.internal.module.ModuleInfo.invalidModuleDescriptor(ModuleInfo.java:1091)
    at java.base/jdk.internal.module.ModuleInfo.doRead(ModuleInfo.java:195)
    at java.base/jdk.internal.module.ModuleInfo.read(ModuleInfo.java:147)
    at java.base/java.lang.module.ModuleDescriptor.read(ModuleDescriptor.java:2553)
    at jdk.jartool/sun.tools.jar.Main.addExtendedModuleAttributes(Main.java:2084)
    at jdk.jartool/sun.tools.jar.Main.update(Main.java:1018)
    at jdk.jartool/sun.tools.jar.Main.run(Main.java:366)
    at jdk.jartool/sun.tools.jar.JarToolProvider.run(JarToolProvider.java:37)
    at java.base/java.util.spi.ToolProvider.run(ToolProvider.java:137)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    at org.codehaus.plexus.archiver.jar.JarToolModularJarArchiver.postCreateArchive(JarToolModularJarArchiver.java:114)
    at org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:1066)
    at org.apache.maven.archiver.MavenArchiver.createArchive(MavenArchiver.java:676)
    at org.apache.maven.plugins.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:276)
    at org.apache.maven.plugins.jar.AbstractJarMojo.execute(AbstractJarMojo.java:307)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)

---

Issue Links:

• MJAR-62 Build-Jdk in Manifest.mf does not reflect which compiler version actually compiled the classes in the jar

Remote Links:

• GitHub Pull Request #71
  
• plexus-archiver issue 238
  

[jira-importer]

Michael Osipov commented

What exactly you expect to see with this plugin? I don't understand.

[jira-importer]

b. ohnsorg commented

Amended the description. I was of the opinion those who are concerned know about the state of MJAR-62 or what Maven toolchains means to maven-jar-plugin – my bad.

[jira-importer]

b. ohnsorg commented

I don't think this is a duplicate of MJAR-62. This bug focuses on toolchains which may not be present at all. Thus MJAR-62 is the more general case and could be solved by implementing toolchain awareness AND using a toolchain in the relevant POM. Without toolchains and the »classic« Maven way maven-jar-plugin still picks the first jar-command it can find = not reliable.

See also the comment I added to MJAR-62 regarding the origin Plexus' JarArchiver.

[jira-importer]

Michael Osipov commented

Reopening...

[hboutemy]

re-reading the issue description: now I get that the report is about a run failure, definitively not a duplicate of MJAR-62 that does not cause any failure but non-representative value: I don't expect MJAR-62 fixed in maven-jar-plugin 3.4.0 will solve this

IIUC, the issue described here is a in Plexus Archiver when using jar command to do modular archive
= https://github.com/codehaus-plexus/plexus-archiver/blob/master/src/main/java/org/codehaus/plexus/archiver/jar/JarToolModularJarArchiver.java that uses jar command from current Maven runtime, not trying to use jar command from toolchain-provided JDK

I'm not a JPMS expert, I don't know how to reproduce: please someone provide a reproducer and we can dive into how Maven can inject a toolchain-provided jar command into plexus-archiver JarToolModularJarArchiver (I don't know precisely how for now...)

[desruisseaux]

Just for information, I plan to propose a refactoring of the JAR plugin, similar to the one done for the compiler plugin, as it is necessary for module source hierarchy as discussed in apache/maven-compiler-plugin#959. If accepted, I would look into this issue in same time. It would be the same approach as for the compiler plugin, i.e. using the javax.tools API with the same mechanism for specifying custom tools (including from the toolchains).

[desruisseaux]

Would be fixed by #495 if accepted.