Drop the cruft #66
Closed
Drop the cruft #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * drop MAT * simplify all the hoops and loops * stop propagating bad practice (passphrase in files on SCM)
gnodet
reviewed
Mar 2, 2024
| @@ -177,7 +188,10 @@ AbstractGpgSigner newSigner(MavenProject project) throws MojoExecutionException, | |||
| signer.setLockMode(lockMode); | |||
| signer.setArgs(gpgArguments); | |||
|
|
|||
| loadGpgPassphrase(); | |||
| String passphrase = System.getenv(MAVEN_GPG_PASSPHRASE); | |||
There was a problem hiding this comment.
Shouldn’t the env variable be configurable with the current value as a default ?
There was a problem hiding this comment.
It could be, yes, even better
|
splitting at least the MAT migration vs the gpg passphrase change would ease review and learning |
Once @olamy or @slawekjaranowski figure out this PR apache/maven-gh-actions-shared#96 (ideally as "v4"), will split this PR into several distinct PRs |
|
This PR is going to be "chopped" into a series of smaller PRs, along the lines for 3.2.0 version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued along the lines of #65
Drop even more cruft
Changes: