V4 gpg v1 #96
Closed
V4 gpg v1 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is used successfully in PR apache/maven-gpg-plugin#65. Whole project had Windows IT failing for quite some long time. Last successful CI run was 2 years ago! |
cstamas
commented
Mar 2, 2024
cstamas
commented
Mar 2, 2024
| @@ -152,6 +152,12 @@ on: | |||
| default: false | |||
| type: boolean | |||
|
|
|||
| install-gpg: | |||
| description: Ensure all build images have GnuPG installed | |||
There was a problem hiding this comment.
Description is somewhat in disparity with what it actually does:
- installs gpg4win (on Windows)
- tests is gpg installed (on all OSes)
There was a problem hiding this comment.
After last commit this is actually fine: on Win it installs (as others does not need it), and on all OS runs gpg --version.
|
Pushed as v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just here to not have it forgotten. This fixes gpg use on Windows that plagued maven-gpg-plugin since quite a long time.