Skip to content

[MBUILDCACHE-123] do not set projectExecutions if cacheState is disabled #288

@jira-importer

Description

@jira-importer

Yu Yu opened MBUILDCACHE-123 and commented

Revised content:

  1. modified {}MojoParametersListener#beforeMojoExecution{}: got cacheState and don't allocate projectExecutions memory if cacheState is disabled.
  2. added sisu-maven-plugin to pom.xml for generating META-INF/sisu/javax.inject.Named which should be included in the maven extension jar.

Cause:
if set maven-build-cache-extension at {}.mvn/extensions.xml{}, MojoParametersListener will always allocate memory for saving projectExecutions even disable the cache by -Dmaven.build.cache.enabled=false
!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!

this pr is related to apache/dubbo#15328


Affects: 1.2.0

Remote Links:

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:majorMajor loss of function

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions