[KYUUBI #4247] build/mvn should use the exact version defined in pom.xml
#4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @edddddy, thanks for your contribution, would you please fill out the PR template, and supply more background? |
Codecov Report
@@ Coverage Diff @@
## master #4261 +/- ##
============================================
- Coverage 53.41% 53.38% -0.03%
Complexity 13 13
============================================
Files 560 560
Lines 30562 30562
Branches 4139 4139
============================================
- Hits 16324 16316 -8
- Misses 12705 12709 +4
- Partials 1533 1537 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
changed the title
build/mvn should use the exact version defined in pom.xml
pan3793
approved these changes
Feb 7, 2023
pan3793
pushed a commit
that referenced
this pull request
Feb 7, 2023
…om.xml` ### _Why are the changes needed?_ As mentioned in #4247, it seems to be better that using the same maven version with master. Thus, modify the version check logic in `build/mvn` from equal or greater to equal. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4261 from edddddy/mvn_ver_cp. Closes #4247 11f19ec [1456173400] change the if condition to equal Lead-authored-by: edddddy <rmrfall@qq.com> Co-authored-by: 1456173400 <1456173400@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 95318d5) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
Thanks, merged to master/1.6 |
3 tasks
pan3793
added a commit
that referenced
this pull request
Feb 9, 2023
### _Why are the changes needed?_ `build/mvn` should download the maven when the local `mvn` version does not match, this corrects the change in #4261 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4291 from pan3793/mvn-version. Closes #4247 42717a7 [Cheng Pan] [KYUUBI #4247][FOLLOWUP] Fix build/mvn version comparison Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
added a commit
that referenced
this pull request
Feb 9, 2023
### _Why are the changes needed?_ `build/mvn` should download the maven when the local `mvn` version does not match, this corrects the change in #4261 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4291 from pan3793/mvn-version. Closes #4247 42717a7 [Cheng Pan] [KYUUBI #4247][FOLLOWUP] Fix build/mvn version comparison Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
As mentioned in #4247, it seems to be better that using the same maven version with master. Thus, modify the version check logic in
build/mvnfrom equal or greater to equal.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request