Skip to content

Commit 95318d5

Browse files
edddddy1456173400
authored andcommitted
[KYUUBI #4247] build/mvn should use the exact version defined in pom.xml
### _Why are the changes needed?_ As mentioned in #4247, it seems to be better that using the same maven version with master. Thus, modify the version check logic in `build/mvn` from equal or greater to equal. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4261 from edddddy/mvn_ver_cp. Closes #4247 11f19ec [1456173400] change the if condition to equal Lead-authored-by: edddddy <rmrfall@qq.com> Co-authored-by: 1456173400 <1456173400@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
1 parent 301185c commit 95318d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/mvn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ install_mvn() {
7676
fi
7777
# See simple version normalization: http://stackoverflow.com/questions/16989598/bash-comparing-version-numbers
7878
function version { echo "$@" | awk -F. '{ printf("%03d%03d%03d\n", $1,$2,$3); }'; }
79-
if [ $(version $MVN_DETECTED_VERSION) -lt $(version $MVN_VERSION) ]; then
79+
if [ $(version $MVN_DETECTED_VERSION) -eq $(version $MVN_VERSION) ]; then
8080
local APACHE_MIRROR=${APACHE_MIRROR:-'https://archive.apache.org/dist/'}
8181

8282
install_app \

0 commit comments

Comments
 (0)