Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Respect hive.server2.thrift.resultset.default.fetch.size configuration in kyuubi server #6338

Closed
3 of 4 tasks
wForget opened this issue Apr 26, 2024 · 4 comments
Closed
3 of 4 tasks

[FEATURE] Respect hive.server2.thrift.resultset.default.fetch.size configuration in kyuubi server #6338

wForget opened this issue Apr 26, 2024 · 4 comments
Assignees
@wForget
Labels
kind:feature Feature request priority:major

Comments

@wForget
Copy link
Member

wForget commented Apr 26, 2024 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Respect hive.server2.thrift.resultset.default.fetch.size configuration in kyuubi server

Motivation

After HIVE-23005, hive driver requires that openSession response from server must contain hive.server2.thrift.resultset.default.fetch.size configuration.

When we use hive driver 4.0+ to connect to kyuubi, we get the following error::

Server returned a null default fetch size. Check that hive.server2.thrift.resultset.default.fetch.size is configured correctly.

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@wForget wForget self-assigned this Apr 26, 2024
wForget added a commit to wForget/kyuubi that referenced this issue Apr 26, 2024
@wForget
[KYUUBI apache#6338] Support `kyuubi.server.thrift.resultset.default.…
ca65349 
…fetch.size` conf
@wForget wForget mentioned this issue Apr 26, 2024
Closed
4 tasks
wForget added a commit that referenced this issue Apr 29, 2024
@wForget
[KYUUBI #6338] Support connecting Kyuubi using Hive JDBC driver 4.0
5942686 
# 🔍 Description
## Issue References 🔗

This pull request fixes #6338

## Describe Your Solution 🔧

Support `kyuubi.server.thrift.resultset.default.fetchsize` conf to respect `hive.server2.thrift.resultset.default.fetch.size` hive conf.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests
KyuubiTBinaryFrontendServiceSuite.test("test kyuubi.server.thrift.resultset.default.fetch.size")

---

# Checklist 📝

- [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6340 from wForget/KYUUBI-6338.

Closes #6338

acd73a1 [wforget] fix
5e64ed3 [wforget] comments
48b8ec6 [wforget] fix style and address comments
ca65349 [wforget] [KYUUBI #6338] Support `kyuubi.server.thrift.resultset.default.fetch.size` conf

Authored-by: wforget <643348094@qq.com>
Signed-off-by: wforget <643348094@qq.com>
(cherry picked from commit ef28a61)
Signed-off-by: wforget <643348094@qq.com>
@scpcy
Copy link

scpcy commented Sep 18, 2024

Still the problem persist using the Hive jdbc driver 4.0

@pan3793
Copy link
Member

pan3793 commented Sep 18, 2024

@scpcy any additional information except for "does not work"?

@scpcy
Copy link

scpcy commented Sep 18, 2024 •
edited
Loading

"erver returned a null default fetch size. Check that hive.server2.thrift.resultset.default.fetch.size is configured correctly."

this is the error I get using kyuubi 1.9.2 using thrift server http protocol
@pan3793

@pan3793
Copy link
Member

pan3793 commented Sep 18, 2024

... using thrift server http protocol

it requires #6648, let me backport it to branch-1.9, and start to discuss 1.9.3 release

@pan3793 pan3793 mentioned this issue Sep 18, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wForget wForget

Labels
kind:feature Feature request priority:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6338] Support connecting Kyuubi using Hive JDBC driver 4.0 wForget/kyuubi
3 participants
@wForget @pan3793 @scpcy