fix style and address comments

apache · Apr 26, 2024 · 48b8ec6 · 48b8ec6
1 parent ca65349
commit 48b8ec6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
@@ -3623,6 +3623,8 @@ object KyuubiConf {
 
   private val HIVE_SERVER2_THRIFT_RESULTSET_DEFAULT_FETCH_SIZE: ConfigEntry[Int] =
     buildConf("hive.server2.thrift.resultset.default.fetch.size")
+      .doc("The number of rows sent in one Fetch RPC call by the server to the client, if not" +
+        " specified by the client. This is a hive server configuration.")
       .internal
       .serverOnly
       .intConf

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTBinaryFrontendService.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTBinaryFrontendService.scala
@@ -97,8 +97,9 @@ final class KyuubiTBinaryFrontendService(
 
       respConfiguration.put(KYUUBI_SESSION_ENGINE_LAUNCH_SUPPORT_RESULT, true.toString)
 
-      // KYUUBI-6338: Set default fetch size
-      respConfiguration.put("hive.server2.thrift.resultset.default.fetch.size",
+      // After HIVE-23005, hive driver requires this conf
+      respConfiguration.put(
+        "hive.server2.thrift.resultset.default.fetch.size",
         defaultFetchSize.toString)
 
       resp.setSessionHandle(sessionHandle.toTSessionHandle)