JSPWIKI-1189 fixes the described issue with unsaved page edits #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was previously present. It needs some i18n updates but this is functional from my limited testing
|
so this builds ok on by end with JDK17. CI says this is the issue: odd since this doesn't change anything related to permissions structures. i'm guessing there some instability in that test case? |
spyhunter99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. it removes the previous modal configuration (pink overlay setup) with a newer html5 based dialog.
i've checked the code and it looks like the only other thing that calls this javascript api is related to jsonrpc. I'm not sure if that's still used or not.
Submitting for feedback
Example presentation is below
and in dark mode
