[IOTDB-31] failed to set float precision when creating timeseries#80
Closed
[IOTDB-31] failed to set float precision when creating timeseries#80
Conversation
Member
|
If you want to avoid But I suggest that you modify this on my PR... because there are heavy conflicts... |
jt2594838
reviewed
Mar 1, 2019
| LOGGER.warn("cannot set max point number to negative value, replaced with default value:{}", | ||
| maxPointNumber); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
It seems that the else block is just enough and the if block is redundant.
You may set maxPointNumber = TSFileConfig.floatPrecision first and then go through the loop for(Map.Entry<String, String> entry : props.entrySet()) .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.