[IOTDB-6]Value filter query optimization#79
Closed
little-emotion wants to merge 12 commits intoaggregatefrom
Closed
[IOTDB-6]Value filter query optimization#79little-emotion wants to merge 12 commits intoaggregatefrom
little-emotion wants to merge 12 commits intoaggregatefrom
Conversation
Beyyes
reviewed
Feb 28, 2019
iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithTimeGenerator.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/query/factory/SeriesReaderFactory.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/BatchData.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/query/reader/merge/PriorityMergeReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
jt2594838
requested changes
Mar 1, 2019
iotdb/src/main/java/org/apache/iotdb/db/query/reader/merge/PriorityMergeReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/query/reader/sequence/SealedTsFilesReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/org/apache/iotdb/db/query/reader/sequence/SequenceDataReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
Member
|
Please resolve conflicts with master and run |
Beyyes
requested changes
Mar 4, 2019
iotdb/src/main/java/org/apache/iotdb/db/query/reader/merge/PriorityMergeReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/query/reader/sequence/SealedTsFilesReaderByTimestamp.java
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/query/reader/sequence/SealedTsFilesReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/query/reader/unsequence/EngineChunkReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
Beyyes
requested changes
Mar 4, 2019
tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/BatchData.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/series/SeriesReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/series/SeriesReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/series/SeriesReaderByTimestamp.java
Show resolved
Hide resolved
| * @return true if has next, false if not. | ||
| * @throws IOException | ||
| */ | ||
| public boolean hasNext() throws IOException { |
Member
There was a problem hiding this comment.
This method need be coveraged all by unit test coverage plugin.
...src/test/java/org/apache/iotdb/db/query/reader/merge/PriorityMergeReaderByTimestampTest.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/query/factory/SeriesReaderFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/query/reader/unsequence/EngineChunkReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
Beyyes
reviewed
Mar 8, 2019
| if (tsPrimitiveType == null) { | ||
| Object value = reader.getValueInTimestamp(timestamp); | ||
| if (value == null) { | ||
| rowRecord.addField(new Field(null)); |
| public class PriorityMergeReaderByTimestamp implements EngineReaderByTimeStamp { | ||
|
|
||
| private List<EngineReaderByTimeStamp> readerList = new ArrayList<>(); | ||
| private List<Integer> priorityList = new ArrayList<>(); |
| public Object getValueInTimestamp(long timestamp) throws IOException { | ||
| Object value = null; | ||
| for (int i = readerList.size() - 1; i >= 0; i--) { | ||
| value = readerList.get(i).getValueInTimestamp(timestamp); |
Member
There was a problem hiding this comment.
just return value, if (value != null) { is no needed
| @Override | ||
| public TsPrimitiveType getValueInTimestamp(long timestamp) throws IOException { | ||
| public Object getValueInTimestamp(long timestamp) throws IOException { | ||
| while (hasNext()) { |
Member
There was a problem hiding this comment.
remove hasNext method and next invoking in this method
Beyyes
approved these changes
Mar 8, 2019
jt2594838
approved these changes
Mar 8, 2019
Member
|
Please solve travis error(merge master) and write an email to briefly describe your work. |
jixuan1989
requested changes
Mar 22, 2019
Member
jixuan1989
left a comment
jixuan1989
left a comment
There was a problem hiding this comment.
This PR is blocked until PR of aggregation is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.