Skip to content

See #385 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

See #385 #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ repo/owner:

> [!NOTE]
> Always pin actions to exact commit SHAs, never use tags or branch references.
> (For historic reasons there are some exceptions to this rule)
Copy link
Member

@raboof raboof Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is accurate: I'm not sure these are actually exceptions to the rule, or just instances where the rule does hold in theory but isn't enforced yet.

Copy link
Contributor Author

@sebbASF sebbASF Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just trying to answer queries such as #385, which may well recur.

Maybe there is a better wording?

I think it would be helpful to document why some actions don't use commit SHAs, contradicting the rule.

Are there circumstances where commit SHAs are not needed for new actions?
If so, again I think this should be documented.

Copy link
Member

@raboof raboof Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. I'll defer to infra on how they'd like this to be characterized.


The infrastructure team will review your request and either approve, request changes, or provide feedback on alternatives.

Expand Down