See #385 #387
Open
See #385 #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Nov 24, 2025
|
|
||
| > [!NOTE] | ||
| > Always pin actions to exact commit SHAs, never use tags or branch references. | ||
| > (For historic reasons there are some exceptions to this rule) |
Member
There was a problem hiding this comment.
I'm not sure this is accurate: I'm not sure these are actually exceptions to the rule, or just instances where the rule does hold in theory but isn't enforced yet.
Contributor
Author
There was a problem hiding this comment.
I was just trying to answer queries such as #385, which may well recur.
Maybe there is a better wording?
I think it would be helpful to document why some actions don't use commit SHAs, contradicting the rule.
Are there circumstances where commit SHAs are not needed for new actions?
If so, again I think this should be documented.
Member
There was a problem hiding this comment.
Yeah, good idea. I'll defer to infra on how they'd like this to be characterized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify pinning policy