Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ private FileIO initTableOps() {
@Override
public InternalTable getTable(Snapshot snapshot) {
Table iceTable = getSourceTable();
Schema iceSchema = iceTable.schemas().get(snapshot.schemaId());
Schema iceSchema =
(snapshot != null) ? iceTable.schemas().get(snapshot.schemaId()) : iceTable.schema();
TableOperations iceOps = ((BaseTable) iceTable).operations();
IcebergSchemaExtractor schemaExtractor = IcebergSchemaExtractor.getInstance();
InternalSchema irSchema = schemaExtractor.fromIceberg(iceSchema);
Expand All @@ -123,12 +124,19 @@ public InternalTable getTable(Snapshot snapshot) {
irPartitionFields.size() > 0
? DataLayoutStrategy.HIVE_STYLE_PARTITION
: DataLayoutStrategy.FLAT;

Instant latestCommitTime =
(snapshot != null)
? Instant.ofEpochMilli(snapshot.timestampMillis())
: Instant.ofEpochMilli(
((BaseTable) iceTable).operations().current().lastUpdatedMillis());

return InternalTable.builder()
.tableFormat(TableFormat.ICEBERG)
.basePath(iceTable.location())
.name(iceTable.name())
.partitioningFields(irPartitionFields)
.latestCommitTime(Instant.ofEpochMilli(snapshot.timestampMillis()))
.latestCommitTime(latestCommitTime)
.readSchema(irSchema)
.layoutStrategy(dataLayoutStrategy)
.latestMetadataPath(iceOps.current().metadataFileLocation())
Expand All @@ -147,6 +155,18 @@ public InternalSnapshot getCurrentSnapshot() {
Table iceTable = getSourceTable();

Snapshot currentSnapshot = iceTable.currentSnapshot();

if (currentSnapshot == null) {
// Handle empty table case - return snapshot with schema but no data files
InternalTable irTable = getTable(null);
return InternalSnapshot.builder()
.version("0")
.table(irTable)
.partitionedDataFiles(Collections.emptyList())
.sourceIdentifier("0")
.build();
}

InternalTable irTable = getTable(currentSnapshot);

TableScan scan =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,37 @@ void getTableTest(@TempDir Path workingDir) throws IOException {
internalTable.getPartitioningFields().get(0).getTransformType());
}

@Test
void testGetTableWithoutSnapshot(@TempDir Path workingDir) throws IOException {
Table emptyTable = createTestCatalogTable(workingDir.toString());
assertNull(emptyTable.currentSnapshot());

SourceTable sourceTableConfig = getPerTableConfig(emptyTable);

IcebergConversionSource conversionSource =
sourceProvider.getConversionSourceInstance(sourceTableConfig);

InternalTable internalTable = conversionSource.getTable(null);
assertNotNull(internalTable);
assertEquals(TableFormat.ICEBERG, internalTable.getTableFormat());
assertEquals(emptyTable.location(), internalTable.getBasePath());
assertEquals(
((BaseTable) emptyTable).operations().current().lastUpdatedMillis(),
internalTable.getLatestCommitTime().toEpochMilli());

assertEquals(
emptyTable.schema().columns().size(), internalTable.getReadSchema().getFields().size());
validateSchema(internalTable.getReadSchema(), emptyTable.schema());

assertEquals(1, internalTable.getPartitioningFields().size());
InternalField partitionField = internalTable.getPartitioningFields().get(0).getSourceField();
assertEquals("cs_sold_date_sk", partitionField.getName());
assertEquals(7, partitionField.getFieldId());
assertEquals(
PartitionTransformType.VALUE,
internalTable.getPartitioningFields().get(0).getTransformType());
}

@Test
public void testGetCurrentSnapshot(@TempDir Path workingDir) throws IOException {
Table catalogSales = createTestTableWithData(workingDir.toString());
Expand Down Expand Up @@ -164,6 +195,45 @@ public void testGetCurrentSnapshot(@TempDir Path workingDir) throws IOException
}
}

@Test
void testGetCurrentSnapshotForEmptyTable(@TempDir Path workingDir) throws IOException {
Table emptyTable = createTestCatalogTable(workingDir.toString());
assertNull(emptyTable.currentSnapshot());

SourceTable sourceTableConfig = getPerTableConfig(emptyTable);

IcebergDataFileExtractor spyDataFileExtractor = spy(IcebergDataFileExtractor.builder().build());
IcebergPartitionValueConverter spyPartitionConverter =
spy(IcebergPartitionValueConverter.getInstance());

IcebergConversionSource conversionSource =
IcebergConversionSource.builder()
.hadoopConf(hadoopConf)
.sourceTableConfig(sourceTableConfig)
.dataFileExtractor(spyDataFileExtractor)
.partitionConverter(spyPartitionConverter)
.build();

InternalSnapshot internalSnapshot = conversionSource.getCurrentSnapshot();
assertNotNull(internalSnapshot);
assertEquals("0", internalSnapshot.getVersion());
assertEquals("0", internalSnapshot.getSourceIdentifier());
assertTrue(internalSnapshot.getPartitionedDataFiles().isEmpty());

InternalTable internalTable = internalSnapshot.getTable();
assertNotNull(internalTable);
assertEquals(emptyTable.location(), internalTable.getBasePath());
assertEquals(
((BaseTable) emptyTable).operations().current().lastUpdatedMillis(),
internalTable.getLatestCommitTime().toEpochMilli());

assertEquals(
emptyTable.schema().columns().size(), internalTable.getReadSchema().getFields().size());

verify(spyPartitionConverter, never()).toXTable(any(), any(), any());
verify(spyDataFileExtractor, never()).fromIceberg(any(), any(), any());
}

@Test
public void testGetTableChangeForCommit(@TempDir Path workingDir) throws IOException {
Table catalogSales = createTestTableWithData(workingDir.toString());
Expand Down