Handle empty Iceberg table source in conversion #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvina
approved these changes
Nov 4, 2025
Contributor
ashvina
left a comment
ashvina
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for the fix!
Could you please link this PR to a GitHub issue that describes the problem before the fix? This will help with traceability and context for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #757
This PR introduce null-checks and fallback logic throughout the conversion in the IcebergConversionSource class to handle empty tables gracefully without data.
Brief change log
IcebergConversionSource.java: Added a conditional for computing the latest commit time when the snapshot is null.
IcebergConversionSource.java: Inserted logic to return a default InternalSnapshot (version "0" with no data files) if the current snapshot is missing.
IcebergConversionSource.java: Updated the getTable method to use a fallback schema when provided snapshot is null.
Verify this pull request