Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: update README.md(update mailing list and repository urls) #6186

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

update mailing list and repository urls

Ⅱ. Does this pull request fix one issue?

fixes #6185

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6186#6184 有必要分开吗?
Is it necessary to separate #6186 and #6184?

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63b29d) 48.95% compared to head (6ca65bb) 49.00%.
Report is 1 commits behind head on 2.x.

❗ Current head 6ca65bb differs from pull request most recent head 1bbe2bb. Consider uploading reports for the commit 1bbe2bb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6186      +/-   ##
============================================
+ Coverage     48.95%   49.00%   +0.04%     
- Complexity     4777     4783       +6     
============================================
  Files           915      915              
  Lines         31890    31890              
  Branches       3853     3853              
============================================
+ Hits          15613    15627      +14     
+ Misses        14715    14700      -15     
- Partials       1562     1563       +1     

see 3 files with indirect coverage changes

@xingfudeshi xingfudeshi reopened this Dec 21, 2023
@xingfudeshi xingfudeshi changed the title Update README.md(update mailing list and repository urls) optimize:update README.md(update mailing list and repository urls) Dec 21, 2023
@funky-eyes funky-eyes changed the title optimize:update README.md(update mailing list and repository urls) optimize: update README.md(update mailing list and repository urls) Dec 21, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 81fc703 into apache:2.x Dec 21, 2023
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mailing list
4 participants