Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Guava Splitter to fix StringSplitter warning #2663

Merged
merged 1 commit into from
Jun 2, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
package org.apache.iceberg.nessie;

import java.time.Instant;
import java.util.List;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.relocated.com.google.common.base.Splitter;

public class TableReference {

private static final Splitter BRANCH_NAME_SPLITTER = Splitter.on("@");
private final TableIdentifier tableIdentifier;
private final Instant timestamp;
private final String reference;
Expand Down Expand Up @@ -77,9 +80,9 @@ public static TableReference parse(String path) {
}

if (path.contains("@")) {
String[] tableRef = path.split("@");
TableIdentifier identifier = TableIdentifier.parse(tableRef[0]);
return new TableReference(identifier, null, tableRef[1]);
List<String> tableRef = BRANCH_NAME_SPLITTER.splitToList(path);
TableIdentifier identifier = TableIdentifier.parse(tableRef.get(0));
return new TableReference(identifier, null, tableRef.get(1));
}

if (path.contains("#")) {
Expand Down