Use Guava Splitter to fix StringSplitter warning #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymurr
reviewed
Jun 2, 2021
nessie/src/main/java/org/apache/iceberg/nessie/TableReference.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
suppress-string-splitter-warn
branch
from
5838618 to
c6519a0
Compare
nastra
changed the title
nastra
force-pushed
the
suppress-string-splitter-warn
branch
from
c6519a0 to
7375eae
Compare
|
Looks like the CI runs didn't trigger and there are some issues w/ github being reported. Once githubs issues are sorted we should close and reopen this to see if CI is correctly triggered. |
|
@rymurr looks like CI was eventually triggered properly and passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code part shouldn't be affected by
https://errorprone.info/bugpattern/StringSplitter as we're checking
explicitly whether the string contains a
@before splitting:if (path.contains("@")).