Repository navigation
fix(struct): exclude optional word from runtime - #3295
Conversation
- keep word as a provided compile and test dependency - omit word and its unused runtime transitives from packages - report a missing optional analyzer dependency clearly - document external installation and test both classpaths
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3295 +/- ##
============================================
+ Coverage 41.87% 41.88% +0.01%
- Complexity 6969 6971 +2
============================================
Files 768 768
Lines 66436 66436
Branches 8831 8831
============================================
+ Hits 27823 27830 +7
+ Misses 35468 35466 -2
+ Partials 3145 3140 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: Moving org.apdplat:word:1.3 to provided scope correctly drops the GPLv3 jar and its runtime transitives from the distribution, and the factory now reports a missing jar as a ConfigException with the cause kept; the only gap is that the release LICENSE and licenses/ directory still declare the transitives this change stops shipping. Evidence: read the exact-head diff of all 6 files plus WordAnalyzer.java and regenerate_known_dependencies.sh (runtime-scope copy-dependencies); grep of install-dist/release-docs/LICENSE and install-dist/release-docs/licenses/ at 83e1284; every latest-head check passes, including dependency-check, check-license and the struct and server suites.
| <artifactId>word</artifactId> | ||
| <version>1.3</version> | ||
| <!-- External optional analyzer; compile/test it without shipping it. --> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Minor: With word in provided scope, this PR removes commons-pool2-2.0, jedis-2.5.1, lucene-backward-codecs-5.2.1, lucene-misc-5.2.1, lucene-suggest-5.2.1 and pinyin4j-2.5.0 from known-dependencies.txt, so the binary package no longer ships them. install-dist/release-docs/LICENSE still lists all six (lines 695, 697, 698, 702, 714 and 769), and install-dist/release-docs/licenses/ still holds LICENSE-commons-pool2-2.0.txt, LICENSE-jedis-2.5.1.txt, LICENSE-lucene-{backward-codecs,misc,suggest}-5.2.1.txt and LICENSE-pinyin4j-2.5.0.txt. That makes the release LICENSE disagree with the bundled jars, which release verification checks. Please remove those six LICENSE entries and their license text files in this PR, so the inventory and LICENSE change together.
Purpose of the PR
Standard distributions bundled GPLv3-only
word:1.3even when its optional analyzer was unused. They now omit that library and its unused runtime dependencies. Users can still install Word separately when explicitly selecting it.Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - Done:docs/BUILDING.md.Doc - No NeedRelated release validation: apache/hugegraph-doc#512.
Related Toolchain SDK packaging: apache/hugegraph-toolchain#794.
Validation uses unsigned local packages; real RC signatures and remote Maven staging remain separate gates.