Repository navigation
refactor: support 1.8.0 release SDK packaging - #794
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=========================================
Coverage 46.60% 46.61%
- Complexity 4439 4440 +1
=========================================
Files 602 602
Lines 29229 29229
Branches 3419 3419
=========================================
+ Hits 13623 13624 +1
Misses 14328 14328
+ Partials 1278 1277 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
26 of 82 tasks
imbajin
marked this pull request as ready for review
October 9, 2026 02:20
4 of 9 tasks
imbajin
commented
Oct 9, 2026
imbajin
left a comment
Member
Author
There was a problem hiding this comment.
Blocking: no. Summary: Candidate build instructions in the Loader and Hubble READMEs still conflict with the new 1.8.0 release defaults. Evidence: Their exact-head commands use a 1.7.0 candidate repository without mode overrides, and the release verifier rejects candidate manifests at .github/scripts/verify_candidate_image_sdk.py:200-201.
- align normal SDK dependencies and release validation with 1.8.0 - preserve locked candidate builds with explicit mode and version - retain source archive build scripts and verify packaged SDK bytes - cover missing libraries, metadata and symlink failures
- select the source SDK version for upstream compatibility - retain locked candidate validation and isolated Maven provenance - verify explicit snapshot SDK versions without changing RC gates - test action exports, manifest placement and integrity failures
- use the Hive core classifier in Loader distributions - remove the embedded legacy Guava from the shared classpath - align Hive packaging with the existing Hubble dependency
- remove the obsolete full Hive executable jar entry - retain the existing Hive core dependency record - preserve strict comparison against generated dependencies
- pin same-source builds and images to the merged 1.8 Server - preserve manifests and verify SDK provenance before selecting Maven coordinates - keep historical Server 1.7 runtime independent of the compilation SDK - align release checks, documentation and dependency metadata
imbajin
force-pushed
the
fix/release-sdk-180
branch
from
October 9, 2026 07:19
2e10692 to
c2c99f6
Compare
- match the complete dependency audit from the 1.8 SDK build - update gRPC and protobuf license coordinates and source references - retain native grants and include the Animal Sniffer MIT notice
- add current Server runtime lanes while retaining the official 1.7 fixtures - share the current Server fixture between Hubble and Go - align fixture fingerprints and result gates without Java SDK inputs for Go
- use hugegraph-toolchain-dist without changing source paths or tar names - retain strict Server distribution hashes and isolate Toolchain outputs - verify the effective Maven coordinates and reactor selector
Disable cached results in live Server tests. Preserve race detection and existing test flags. Run requests for both supported Server baselines.
zyxxoo
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain now builds with Java 17 and the 1.8.0 SDK while testing current Server 1.8.0 and released Server 1.7.0 separately. Historical Server compatibility no longer changes the SDK used to compile Toolchain.
Source compatibility checks retain the full Server revision, manifest and SDK file verification. Release builds use the selected Maven staging repository with an isolated local repository; required verification scripts are included in source archives.
The ordinary Loader uses Hive's existing core classifier to avoid embedded Guava conflicts. Dependency inventory, LICENSE/NOTICE and build instructions match the 1.8 SDK. Toolchain's dist artifact becomes
hugegraph-toolchain-dist, preventing collision with Server'shugegraph-dist; release tar names stay unchanged.Client, Loader, Tools, Hubble, Spark Connector and Go have current/historical Server runtime lanes. Go explicitly disables test-result caching so each lane executes requests against its selected Server.
Validation: real Maven builds, source archive checks, dependency checks and the latest current/historical Server runtime jobs passed, including fresh Go requests with test-result caching disabled. The final CI aggregation check is still waiting for a runner. Doc package validation rebuilt both projects and passed Server, Client, ordinary Loader, Tools and Hubble on source-built and binary distributions. Signed RC and actual remote staging validation remain pending; signing/uploading belong to the release manager's separate publisher workflow.
Related: Doc validator, merged Server packaging fix.