Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Merge logs into check instant file of HoodieActiveTimeline.transitionPendingState #10392

Merged
merged 2 commits into from
Dec 23, 2023
Merged

[MINOR] Merge logs into check instant file of HoodieActiveTimeline.transitionPendingState #10392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
594e134
add log
zhuanshenbsj1 Dec 21, 2023
96e0744
Update hudi-common/src/main/java/org/apache/hudi/common/table/timelin…
zhuanshenbsj1 Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,8 +695,8 @@ protected void transitionPendingState(HoodieInstant fromInstant, HoodieInstant t
}
} else {
// Ensures old state exists in timeline
LOG.info("Checking for file exists ?" + getInstantFileNamePath(fromInstantFileName));
ValidationUtils.checkArgument(metaClient.getFs().exists(getInstantFileNamePath(fromInstantFileName)));
ValidationUtils.checkArgument(metaClient.getFs().exists(getInstantFileNamePath(fromInstantFileName)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuanshenbsj1 : Looks like you are removing log message while the title says adding log. what is the reason for this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like he merged the log msg into the exception msg, make sense somehow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception information here is not clear. I want to move the log to exception info， to clearly inform the user of the reason for the exception.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good. Thanks both for the clarification

"File " + getInstantFileNamePath(fromInstantFileName) + " does not exist!");
// Use Write Once to create Target File
if (allowRedundantTransitions) {
FileIOUtils.createFileInPath(metaClient.getFs(), getInstantFileNamePath(toInstantFileName), data);
Expand Down
Loading