[MINOR] Merge logs into check instant file of HoodieActiveTimeline.transitionPendingState #10392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaradar
reviewed
Dec 21, 2023
| @@ -695,8 +695,8 @@ protected void transitionPendingState(HoodieInstant fromInstant, HoodieInstant t | |||
| } | |||
| } else { | |||
| // Ensures old state exists in timeline | |||
| LOG.info("Checking for file exists ?" + getInstantFileNamePath(fromInstantFileName)); | |||
| ValidationUtils.checkArgument(metaClient.getFs().exists(getInstantFileNamePath(fromInstantFileName))); | |||
| ValidationUtils.checkArgument(metaClient.getFs().exists(getInstantFileNamePath(fromInstantFileName)), | |||
There was a problem hiding this comment.
@zhuanshenbsj1 : Looks like you are removing log message while the title says adding log. what is the reason for this change?
There was a problem hiding this comment.
It looks like he merged the log msg into the exception msg, make sense somehow.
There was a problem hiding this comment.
The exception information here is not clear. I want to move the log to exception info， to clearly inform the user of the reason for the exception.
There was a problem hiding this comment.
Sound good. Thanks both for the clarification
danny0405
reviewed
Dec 22, 2023
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
…e/HoodieActiveTimeline.java Co-authored-by: Danny Chan <yuzhao.cyz@gmail.com>
danny0405
changed the title
zhuanshenbsj1
changed the title
bvaradar
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Before modification：
Make the Exception information more clearer .
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist