Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xor filter build #666

Merged
merged 3 commits into from
Feb 27, 2023
Merged

fix: xor filter build #666

merged 3 commits into from
Feb 27, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Feb 27, 2023

Which issue does this PR close?

Closes #

Rationale for this change

In #631 xor filter is introduced, however there is one bug on that PR, filter is not built correctly.

What changes are included in this PR?

  • Fix xor filter build
  • Add string type testcase in min-max prune

Are there any user-facing changes?

No

How does this change test

Newly added UT.

@jiacai2050 jiacai2050 changed the title test: add string column testcase fix: xor filter build Feb 27, 2023
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #666 (e450107) into main (ce9fa87) will increase coverage by 0.39%.
The diff coverage is 89.83%.

❗ Current head e450107 differs from pull request most recent head cbd5305. Consider uploading reports for the commit cbd5305 to get more accurate results

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   66.94%   67.34%   +0.39%     
==========================================
  Files         283      283              
  Lines       43969    44519     +550     
==========================================
+ Hits        29435    29980     +545     
- Misses      14534    14539       +5     
Impacted Files Coverage Δ
analytic_engine/src/instance/engine.rs 64.03% <ø> (ø)
analytic_engine/src/lib.rs 98.76% <ø> (ø)
components/arrow_ext/src/display.rs 0.00% <ø> (ø)
server/src/config.rs 37.20% <0.00%> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
server/src/mysql/writer.rs 55.88% <0.00%> (-0.67%) ⬇️
wal/src/lib.rs 100.00% <ø> (ø)
wal/src/manager.rs 90.43% <ø> (-0.12%) ⬇️
analytic_engine/src/table/data.rs 91.43% <50.00%> (-0.22%) ⬇️
common_types/src/column.rs 62.46% <58.06%> (+1.43%) ⬆️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiacai2050 jiacai2050 added this pull request to the merge queue Feb 27, 2023
Merged via the queue into apache:main with commit 617ca95 Feb 27, 2023
@jiacai2050 jiacai2050 deleted the test-prune branch February 27, 2023 08:00
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* test: add string column testcase

* init when builder is none

* add testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants