-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace bloom with xor8 filter #631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-add-xor
branch
from
February 9, 2023 13:50
bc77f15
to
31c55eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
==========================================
- Coverage 66.41% 66.40% -0.02%
==========================================
Files 283 283
Lines 44257 44303 +46
==========================================
+ Hits 29393 29419 +26
- Misses 14864 14884 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rachelint
reviewed
Feb 13, 2023
Rachelint
reviewed
Feb 13, 2023
jiacai2050
force-pushed
the
feat-add-xor
branch
from
February 13, 2023 06:56
b4191fa
to
583463e
Compare
Rachelint
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: add xor8 * fix test * rename bloom * remove unsed fns * rename files * rename sst filter to parquet filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #510
Rationale for this change
See issue above
What changes are included in this PR?
Filter
trait to represent different filtersAre there any user-facing changes?
No
How does this change test
Old UT