Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace bloom with xor8 filter #631

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #510

Rationale for this change

See issue above

What changes are included in this PR?

  • Replace bloom with xor8 filter
  • Add Filter trait to represent different filters

Are there any user-facing changes?

No

How does this change test

Old UT

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #631 (583463e) into main (2819d5e) will decrease coverage by 0.02%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   66.41%   66.40%   -0.02%     
==========================================
  Files         283      283              
  Lines       44257    44303      +46     
==========================================
+ Hits        29393    29419      +26     
- Misses      14864    14884      +20     
Impacted Files Coverage Δ
analytic_engine/src/sst/writer.rs 3.57% <ø> (ø)
...nalytic_engine/src/sst/parquet/row_group_pruner.rs 78.65% <62.96%> (ø)
analytic_engine/src/sst/meta_data/cache.rs 96.72% <66.66%> (ø)
analytic_engine/src/sst/parquet/meta_data.rs 82.70% <84.74%> (-3.94%) ⬇️
analytic_engine/src/sst/parquet/async_reader.rs 89.14% <86.66%> (-0.09%) ⬇️
analytic_engine/src/sst/parquet/writer.rs 98.17% <92.30%> (-0.01%) ⬇️
analytic_engine/src/compaction/picker.rs 84.28% <100.00%> (ø)
analytic_engine/src/sst/parquet/encoding.rs 95.42% <100.00%> (ø)
components/parquet_ext/src/prune/equal.rs 97.37% <100.00%> (ø)
components/parquet_ext/src/prune/min_max.rs 92.90% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Feb 13, 2023
Merged via the queue into apache:main with commit b7a2a7d Feb 13, 2023
@jiacai2050 jiacai2050 deleted the feat-add-xor branch February 13, 2023 09:51
@jiacai2050 jiacai2050 mentioned this pull request Feb 27, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: add xor8

* fix test

* rename bloom

* remove unsed fns

* rename files

* rename sst filter to parquet filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xor Filters: Faster and Smaller Than Bloom Filters
3 participants