feat: define partition rule trait #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
reviewed
Dec 21, 2022
Rachelint
force-pushed
the
partition-rule
branch
from
eecf1a8
to
437dcab
Compare
Rachelint
changed the title
Rachelint
force-pushed
the
partition-rule
branch
from
225e345
to
5b63bb8
Compare
Rachelint
force-pushed
the
partition-rule
branch
from
5b63bb8
to
1893ccd
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* define partition rule trait. * address CR. * add a mock impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Part of #492
Rationale for this change
See #492 .
Define the trait for other modules' later development.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Not need temporarily.