Skip to content

Commit

Permalink
address CR.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachelint committed Dec 21, 2022
1 parent 437dcab commit 1893ccd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions table_engine/src/partition/rule.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ define_result!(Error);

/// Partition rule locate partition
pub trait PartitionRule {
/// Locate the partition for each row in `row_group`
/// Locate the partition for each row in `row_group`.
///
/// Len of returned value should be equal to the one of rows in `row group`.
fn locate_partitions_for_write(row_group: &RowGroup) -> Vec<usize>;
fn locate_partitions_for_write(&self, row_group: &RowGroup) -> Result<Vec<usize>>;

/// locate partitions according to `filters`
fn locate_partitions_for_read(filters: &[PartitionFilter]) -> Vec<usize>;
/// Locate partitions according to `filters`.
fn locate_partitions_for_read(&self, filters: &[PartitionFilter]) -> Result<Vec<usize>>;
}

/// Filter using for partition
Expand Down

0 comments on commit 1893ccd

Please sign in to comment.