feat: convert table name to quoted style #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
convert-table-name-quoted-style
branch
2 times, most recently
from
babaf3a
to
17a42a9
Compare
Rachelint
force-pushed
the
convert-table-name-quoted-style
branch
3 times, most recently
from
491cae6
to
2cf3c3c
Compare
ShiKaiWi
reviewed
Dec 7, 2022
Rachelint
force-pushed
the
convert-table-name-quoted-style
branch
2 times, most recently
from
499e6ae
to
f37b27e
Compare
Rachelint
force-pushed
the
convert-table-name-quoted-style
branch
from
f37b27e
to
2ec396c
Compare
Rachelint
force-pushed
the
convert-table-name-quoted-style
branch
from
2ec396c
to
15bcd41
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* convert table name to quoted style in sql statement. * add unit test. * revert pr444(apache#444). * refactor related integration tests. * remove useless commets. * refactor the way of extracting table name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
For #442 .
Now we convert table name to quoted style to prevent
datafusionfrom converting it to lowercase.What changes are included in this PR?
All changes are in
sql/src/parser.rs.Main steps:
select ast.select ast.Are there any user-facing changes?
Table name in ceresdb will be case-sensitive.
How does this change test
Test by ut and integrated test.