Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert table name to lowercase when not quoted #444

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Dec 2, 2022

Which issue does this PR close?

Part of #442

Rationale for this change

What changes are included in this PR?

Change table name to lowercase when not quoted

Are there any user-facing changes?

Yes, table name will be converted to lowercase when not quoted

How does this change test

Test harness

@jiacai2050 jiacai2050 changed the title add testcase feat: convert table name to lowercase when not quoted Dec 2, 2022
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Rachelint Rachelint merged commit 61b03dc into apache:main Dec 2, 2022
@jiacai2050 jiacai2050 deleted the feat-normalize-identifier branch December 2, 2022 06:19
Rachelint pushed a commit to Rachelint/ceresdb that referenced this pull request Dec 2, 2022
Rachelint added a commit to Rachelint/ceresdb that referenced this pull request Dec 7, 2022
Rachelint added a commit to Rachelint/ceresdb that referenced this pull request Dec 7, 2022
Rachelint added a commit to Rachelint/ceresdb that referenced this pull request Dec 7, 2022
ShiKaiWi pushed a commit that referenced this pull request Dec 7, 2022
* convert table name to quoted style in sql statement.

* add unit test.

* revert pr444(#444).

* refactor related integration tests.

* remove useless commets.

* refactor the way of extracting table name.
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* convert table name to quoted style in sql statement.

* add unit test.

* revert pr444(apache#444).

* refactor related integration tests.

* remove useless commets.

* refactor the way of extracting table name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants