-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27802 Manage static javascript resources programatically #7032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27802 Manage static javascript resources programatically #7032
Conversation
…dum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.
This is a backport of #6864 to I cherry-picked the master commit and resolved the conflicts. The reason this patch was not applying clearly is that on master we have the website and the reference guide (asciidoc) building code but on other branches we don't. I tested this backported patch the same way as I described here: #6864 (comment) |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There were test failures (because of "Master not active after 30000ms") in the PR build but to me those look unrelated. |
As is
Currently, the static JavaScript, CSS resources need to be manually managed. That is, if any of these has to be updated, we will be required to download them from web and place them under the appropriate path. This can be cumbersome.
After
To be able to manage them with minimal manual effort we could manage them as part of build.
Approach
This solution is very similar to how we manage the websitestatic resources in our build: #6668
Download and extract the UI resources as webjars using the
maven-dependency-plugin
in our build. It will only copy the required files to thehbase-server/target/hbase-webapps/static
directory.The REST and Thrift projects copies the static JavaScript, CSS resources from hbase-server - as before.
This way the no new dependency is packaged into the application, only the required JS, CSS files are copied and packaged.
Upgrading in the future
From now on upgrading the static JavaScript, CSS resources means to:
pom.xml
.Upgrades
Also upgraded the following static resources to current latest version: