Skip to content

HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented May 22, 2025

Popovers ("Metrics" menu) were not working on the UI and the following JS error was logged to browser console:

Uncaught TypeError: i.createPopper is not a function

This is because popper.js was not available on the page for Bootstrap.

Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.

@PDavid PDavid changed the title HBASE-27802 Fix not working popovers on UI HBASE-27802 Fix not working popovers on UI (addendum) May 22, 2025
@PDavid PDavid changed the title HBASE-27802 Fix not working popovers on UI (addendum) HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) May 22, 2025
…dum: Fix not working popovers on UI)

Popovers were not working on the UI and the following JS error was logged to browser console:

```
Uncaught TypeError: i.createPopper is not a function
```

This is because popper.js was not available on the page for Bootstrap.

Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 4m 38s master passed
+1 💚 compile 5m 11s master passed
+1 💚 spotless 1m 1s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 14s the patch passed
+1 💚 compile 4m 59s the patch passed
+1 💚 javac 4m 59s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 13m 13s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 49s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
44m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7018/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7018
Optional Tests dupname asflicense javac codespell detsecrets spotless xmllint hadoopcheck compile
uname Linux 0ccda74bb2da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / afdb24c
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7018/1/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid
Copy link
Contributor Author

PDavid commented May 23, 2025

There are failing unit tests in the PR build but to me those look unrelated.

@PDavid PDavid marked this pull request as ready for review May 23, 2025 12:15
@PDavid
Copy link
Contributor Author

PDavid commented May 23, 2025

Hi @NihalJain and @ndimiduk,
Can you please review this addendum fix? Many thanks in advance. 🙏

@NihalJain
Copy link
Contributor

+1, LGTM

@ndimiduk
Copy link
Member

The build timed out

@ndimiduk ndimiduk merged commit 823563a into apache:master May 23, 2025
1 check failed
@PDavid PDavid deleted the HBASE-27802-fix-popovers-addendum branch May 23, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants