-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) #7018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ndimiduk
merged 1 commit into
apache:master
from
PDavid:HBASE-27802-fix-popovers-addendum
May 23, 2025
Merged
HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) #7018
ndimiduk
merged 1 commit into
apache:master
from
PDavid:HBASE-27802-fix-popovers-addendum
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.
c3004bd
to
afdb24c
Compare
🎊 +1 overall
This message was automatically generated. |
There are failing unit tests in the PR build but to me those look unrelated. |
Hi @NihalJain and @ndimiduk, |
NihalJain
approved these changes
May 23, 2025
+1, LGTM |
ndimiduk
approved these changes
May 23, 2025
The build timed out |
This was referenced May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popovers ("Metrics" menu) were not working on the UI and the following JS error was logged to browser console:
This is because popper.js was not available on the page for Bootstrap.
Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.