HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) #5684

anmolnar · 2024-02-15T16:02:39Z

Backported to branch-2.4

…apache#5669) Signed-off-by: Balazs Meszaros <meszibali@apache.org>

Apache-HBase · 2024-02-15T16:21:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 9s	branch-2.4 passed
+1 💚	compile	0m 15s	branch-2.4 passed
+1 💚	shadedjars	3m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 58s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	3m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 25s	hbase-common in the patch passed.
		15m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 31431ca9c1d7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/testReport/
Max. process+thread count	326 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-15T16:26:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 21s	branch-2.4 passed
+1 💚	compile	0m 21s	branch-2.4 passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 30s	hbase-common in the patch passed.
		20m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 164cc2144cab 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/testReport/
Max. process+thread count	334 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-15T16:37:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 20s	branch-2.4 passed
+1 💚	compile	0m 37s	branch-2.4 passed
+1 💚	checkstyle	0m 16s	branch-2.4 passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 39s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 0s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
-1 ❌	spotless	0m 14s	patch has 28 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		31m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4c1587afe319 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-17T14:52:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 14s	branch-2.4 passed
+1 💚	compile	0m 15s	branch-2.4 passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 59s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 37s	hbase-common in the patch passed.
		16m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ea65e8685099 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/testReport/
Max. process+thread count	339 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-17T14:53:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 33s	branch-2.4 passed
+1 💚	compile	0m 14s	branch-2.4 passed
+1 💚	shadedjars	4m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	4m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 50s	hbase-common in the patch passed.
		18m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9f1c4b0f6c01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/testReport/
Max. process+thread count	333 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-17T15:03:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	2m 37s	branch-2.4 passed
+1 💚	compile	0m 29s	branch-2.4 passed
+1 💚	checkstyle	0m 12s	branch-2.4 passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 28s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 0s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		27m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5684
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7d1d43640a15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `c4b5ac9`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5684/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anmolnar · 2024-02-19T16:32:45Z

@meszibalu Build is green now, I think you're good to merge.

…andled by HBase (branch-2.4) (apache#5684) Signed-off-by: Balazs Meszaros <meszibali@apache.org> (cherry picked from commit 2546823) Change-Id: I037bcdc338656246bd0b1510f9a77c7ade933512

HBASE-28340. Use all Zk client properties that is found in HBase conf (…

ed390d3

…apache#5669) Signed-off-by: Balazs Meszaros <meszibali@apache.org>

anmolnar changed the title ~~HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2)~~ HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) Feb 15, 2024

meszibalu approved these changes Feb 15, 2024

View reviewed changes

HBASE-28340. Spotless fix

e872ccd

meszibalu merged commit 2546823 into apache:branch-2.4 Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) #5684

HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) #5684

Uh oh!

anmolnar commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

anmolnar commented Feb 19, 2024

Uh oh!

Uh oh!

HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) #5684

HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) #5684

Uh oh!

Conversation

anmolnar commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 15, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

Apache-HBase commented Feb 17, 2024

Uh oh!

anmolnar commented Feb 19, 2024

Uh oh!

Uh oh!