HBASE-26983 Upgrade JRuby to 9.3.4.0 #4378

busbey · 2022-04-28T02:30:40Z

No description provided.

busbey · 2022-04-28T02:31:01Z

I'm having trouble running unit tests locally. please wait to merge.

petersomogyi

The java_kind_of? expression was removed in 9.3.0.0 so this line needs to be updated: https://github.com/apache/hbase/blob/master/hbase-shell/src/main/ruby/hbase/security.rb#L185

jruby/jruby#6862

petersomogyi · 2022-05-02T14:59:59Z

pom.xml

@@ -799,7 +799,7 @@
    <wx.rs.api.version>2.1.1</wx.rs.api.version>
    <glassfish.jsp.version>2.3.2</glassfish.jsp.version>
    <glassfish.el.version>3.0.1-b08</glassfish.el.version>
-    <jruby.version>9.2.13.0</jruby.version>
+    <jruby.version>9.3.4.0</jruby.version>


The joni/jcoding versions might need to be updated as well. See the comment on line 818.

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby

Apache-HBase · 2022-05-29T07:12:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	6m 10s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	6m 6s	the patch passed
+1 💚	javac	6m 6s	the patch passed
-0 ⚠️	rubocop	0m 4s	The patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 46s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		37m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	dupname asflicense javac spotless rubocop hadoopcheck xml compile
uname	Linux 83bd675c4cc2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf0ed2e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	139 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-29T10:32:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	1m 50s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	1m 50s	the patch passed
+1 💚	javac	1m 50s	the patch passed
+1 💚	shadedjars	3m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	the patch passed
		_ Other Tests _
-1 ❌	unit	212m 59s	root in the patch failed.
		236m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8b1b59fde503 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf0ed2e`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/testReport/
Max. process+thread count	2574 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-29T12:39:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 55s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	341m 51s	root in the patch failed.
		364m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a211e970eedb 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf0ed2e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/testReport/
Max. process+thread count	3629 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

busbey · 2022-05-29T23:52:24Z

the unit tests passed in the hbase-shell module. the failures that happened in other modules for the most part are some class not found exceptions around leveldbjni. sounds like maybe fall out from HBASE-27065 (fyi @apurtell )

Apache-HBase · 2022-05-31T15:40:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 17s	master passed
-1 ❌	compile	1m 0s	root in master failed.
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	6m 11s	the patch passed
-0 ⚠️	javac	6m 11s	root generated 1373 new + 2 unchanged - 0 fixed = 1375 total (was 2)
-0 ⚠️	rubocop	0m 3s	The patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 34s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		31m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	dupname asflicense javac spotless rubocop hadoopcheck xml compile
uname	Linux f865d6e3e003 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ce85aa`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/branch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-31T19:05:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	3m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	3m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	the patch passed
		_ Other Tests _
-1 ❌	unit	212m 49s	root in the patch failed.
		236m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8dfb2ac4c74c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ce85aa`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/testReport/
Max. process+thread count	2958 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-31T21:49:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 57s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 7s	hbase-shell in the patch passed.
+1 💚	javadoc	1m 23s	root generated 0 new + 83 unchanged - 1 fixed = 83 total (was 84)
		_ Other Tests _
-1 ❌	unit	374m 59s	root in the patch failed.
		398m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4378
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a2507c5f8935 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4ce85aa`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/testReport/
Max. process+thread count	3796 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit d1149f7)

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org>

This reverts commit f29f669.

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit d1149f7)

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit d1149f7) Change-Id: I586c02263dbec0fbfc653a3c650cd2f94c329e90

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit d1149f7) Change-Id: I586c02263dbec0fbfc653a3c650cd2f94c329e90 (cherry picked from commit 1934999)

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit d1149f7) (cherry picked from commit ca6f73792ac3a16a4810b9b372dc99452829f363)

This comment was marked as outdated.

Sign in to view

petersomogyi reviewed May 2, 2022

View reviewed changes

HBASE-26983 Upgrade JRuby to 9.3.4.0

cd36d57

- Update JRuby - Replace java_kind_of since it has been removed - update jcoding / joni to match jruby

busbey force-pushed the HBASE-26983 branch from eb899d5 to cd36d57 Compare May 29, 2022 06:29

busbey requested a review from petersomogyi May 29, 2022 23:52

petersomogyi approved these changes May 31, 2022

View reviewed changes

busbey merged commit d1149f7 into apache:master Jun 5, 2022

busbey deleted the HBASE-26983 branch June 5, 2022 05:16

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)"

cd3de95

This reverts commit f29f669.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26983 Upgrade JRuby to 9.3.4.0 #4378

HBASE-26983 Upgrade JRuby to 9.3.4.0 #4378

Uh oh!

busbey commented Apr 28, 2022

Uh oh!

busbey commented Apr 28, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

petersomogyi left a comment

Uh oh!

petersomogyi May 2, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

busbey commented May 29, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Uh oh!

HBASE-26983 Upgrade JRuby to 9.3.4.0 #4378

HBASE-26983 Upgrade JRuby to 9.3.4.0 #4378

Uh oh!

Conversation

busbey commented Apr 28, 2022

Uh oh!

busbey commented Apr 28, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

petersomogyi May 2, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

busbey commented May 29, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Uh oh!