HBASE-23257: Track clusterID in stand by masters (#798) #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements a simple cache that all the masters can lookup to serve cluster ID to clients. Active HMaster is still responsible for creating it but all the masters will read it from fs to serve clients. RPCs exposing it will come in a separate patch as a part of HBASE-18095. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com> (cherry picked from commit c2e01f2)
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Jan 29, 2020
| private ClusterId clusterId; | ||
|
|
||
| // cache stats for testing. | ||
| private AtomicInteger cacheMisses = new AtomicInteger(0); |
There was a problem hiding this comment.
Nit: A bit wasteful to have this just for a test?
There was a problem hiding this comment.
Agree... wish Java had C++ like macros that we could use to inject DEBUG only code :D.
This code also exists in the master, I'll have to cleanup from there. Can I do it as a follow up?
|
Will be merged as a part of #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a simple cache that all the masters
can lookup to serve cluster ID to clients. Active HMaster
is still responsible for creating it but all the masters
will read it from fs to serve clients.
RPCs exposing it will come in a separate patch as a part of
HBASE-18095.
Signed-off-by: Andrew Purtell apurtell@apache.org
Signed-off-by: Wellington Chevreuil wchevreuil@apache.org
Signed-off-by: Guangxu Cheng guangxucheng@gmail.com
(cherry picked from commit c2e01f2)