HBASE-23304: RPCs needed for client meta information lookup (apache#904) #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements a simple cache that all the masters can lookup to serve cluster ID to clients. Active HMaster is still responsible for creating it but all the masters will read it from fs to serve clients. RPCs exposing it will come in a separate patch as a part of HBASE-18095. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com> (cherry picked from commit c2e01f2)
…ache#812) Currently we just track whether an active master exists. It helps to also track the address of the active master in all the masters to help serve the client RPC requests to know which master is active. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit efebb84)
* HBASE-23281: Track meta region changes on masters This patch adds a simple cache that tracks the meta region replica locations. It keeps an eye on the region movements so that the cached locations are not stale. This information is used for servicing client RPCs for connections that use master based registry (HBASE-18095). The RPC end points will be added in a separate patch. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 8571d38)
* HBASE-23304: RPCs needed for client meta information lookup This patch implements the RPCs needed for the meta information lookup during connection init. New tests added to cover the RPC code paths. HBASE-23305 builds on this to implement the client side logic. Fixed a bunch of checkstyle nits around the places the patch touches. Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 4f8fbba)
|
🎊 +1 overall
This message was automatically generated. |
This was referenced Jan 29, 2020
|
@bharathv @apurtell What exactly was this commit? The message looks like it contains everything from the feature branch, but the changed files is just HBASE-23304. Anyway, we haven't merged the feature branch to master yet; we're not quite ready to back port to branch-2. I think this should be reverted. |
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Feb 3, 2020
…pache#904) (apache#1098)" This reverts commit 71f0354.
|
Ya, so this is a squashed commit up until HBASE-23304. I'm ok with reverting it. I can submit a single PR with all the commits later, once the feature branch merges with master. |
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Feb 3, 2020
…pache#904) (apache#1098)" This reverts commit 71f0354.
|
Copying my comment from the JIRA: There were multiple PRs opened for the same set of changes. I merged the one @bharathv indicated. If you want to do it per JIRA per branch, fine. One PR per JIRA per branch. However that's a lot of noise for what it's worth. I think it better one PR/merge for the whole backport per branch, with commit message incorporating all relevant JIRA references. These changes for the most part aren't useful in isolation. |
|
I see your reasoning. Squishing all the commits makes accounting more difficult, IMHO. The larger issue is that we're still stabilizing the tests vs. master; none of these commits have landed on master yet. |
|
I should say -- I propose one PR per branch containing all the commits, but land it using "rebase and merge" instead of "squash and merge" so that the individual commits are preserved. That make the accounting I refer to simpler. Agreed there's no need for one PR per commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the RPCs needed for the meta information
lookup during connection init. New tests added to cover the RPC
code paths. HBASE-23305 builds on this to implement the client
side logic.
Fixed a bunch of checkstyle nits around the places the patch
touches.
Signed-off-by: Andrew Purtell apurtell@apache.org