-
Notifications
You must be signed in to change notification settings - Fork 167
Clean up repo for first ASF release (Attempt 2) #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
61f3174
Remove `setup.py`
cswartzvi 0dafc37
Remove requirements files
cswartzvi 15b7e75
Move top-level pngs to `assets`
cswartzvi b6b7ca1
Move misc MD files to `wirteups`
cswartzvi 9f47900
Move `build_conda.sh` to `scripts`
cswartzvi 3fd27fe
Move `README-DOCS` to `docs`
cswartzvi fa0496a
Remove legacy style config (us `ruff` instead)
cswartzvi 2290954
Utilize dependency groups (PEP 735) for internal dependencies
cswartzvi 644f3ab
Bump min python to 3.8.1 for uv's universal solver
cswartzvi 5ba470c
Remove flake8 pre-commit
cswartzvi cb306bd
Add `Selector` to `get_type_hints` namespace
cswartzvi 634cd6b
Fix Python 3.0 dependency on `libconv`
cswartzvi 7b1fd60
Fix formatting
cswartzvi fd4a47a
Fix Python 3.0 dependency on `libconv-hook`
cswartzvi 2796b6b
Install `build-essential` during action
cswartzvi 4b07177
Only add `Selector` to `PolarsSpreadsheetWriter` type hint check in P…
cswartzvi 6e78f8b
Use `docs` dependency group
cswartzvi f056f59
Exclude `docs/README.md` from the docs
cswartzvi 38c2884
Add `zlib1g-dev` action Linux dependency
cswartzvi 1766f57
Add `libiconv-dev` as linux action dependency
cswartzvi aad271c
Pin ; remove build tools
cswartzvi 06825ad
Fix python version in `pyreadstat` pin
cswartzvi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| include requirements.txt | ||
| include requirements-test.txt | ||
| include LICENSE | ||
| include *.md | ||
| include NOTICE | ||
|
|
||
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, that this PR requires using pip 25.1 which added installing groups, but also dropped support for python 3.8, so we should work towards droppng support for py38.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jernejfrank, thanks for taking a look. I completely agree with you regarding dropping py38 support. Originally, I was going to include that in this PR, but it started to feel like mission creep. Changing the minimum to
3.8.1was just enough to getuv syncworking reliably without using prereleases (which was also causing issues).I am going to open another PR after this one that drops py38 support - provided there are no objection from the other members of the PMC team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me, also feel it is better to separate it out into another PR!