-
Notifications
You must be signed in to change notification settings - Fork 167
Clean up repo for first ASF release (Attempt 2) #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Charles Swartz <charles.w.swartz.vi@gmail.com>
|
@skrawcz - using a branch on the main repo (and not from my fork) seems to have fixed the issue with the failing docs action. |
jernejfrank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a minor comment from my side.
| description = "Hamilton, the micro-framework for creating dataframes." | ||
| readme = "README.md" | ||
| requires-python = ">=3.8, <4" | ||
| requires-python = ">=3.8.1, <4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, that this PR requires using pip 25.1 which added installing groups, but also dropped support for python 3.8, so we should work towards droppng support for py38.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jernejfrank, thanks for taking a look. I completely agree with you regarding dropping py38 support. Originally, I was going to include that in this PR, but it started to feel like mission creep. Changing the minimum to 3.8.1 was just enough to get uv sync working reliably without using prereleases (which was also causing issues).
I am going to open another PR after this one that drops py38 support - provided there are no objection from the other members of the PMC team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me, also feel it is better to separate it out into another PR!
|
@cswartzvi please add a nice squash commit message to mention and relevant decisions you made here :) |
Hi all - I was looking through the codebase to help create the first ASF release (#1336) and thought we might benefit from a little clean-up. Please have a look and let me know if I went too far with anything - happy to roll things back!
NOTE: This is a follow-up to the closed issue #1371
Changes
assetsfolder. Do we need to keep these?docsorwriteups. Maybe these should be fully integrated with the docs?setup.py, removing the legacy Python packaging script and related logic.style.yapf,.flake8, ...)3.8.1. This allows contributors to useuv syncwithout allowing prereleases (as per the last meetup, I would like bump the min required python to3.9next)uvconfiguration. Sincepipnow has support, I moved dev dependencies todependency-groups(PEP 735)(maybe out of scope for this PR)How I tested this
No changes to codebase
Notes
N/A
Checklist