add license headers to source files #1360 #1369
Conversation
|
Thanks @Gophersen -- I scanned these and they look good. I'll let @pjfanning take a quick scan too. I'll merge in a couple of days if I don't hear from PJ. |
There was a problem hiding this comment.
Actually can you add these headers to these folders too please -- sorry just realized that these weren't in there:
https://github.com/apache/hamilton/tree/main/contrib
https://github.com/apache/hamilton/tree/main/dev_tools
https://github.com/apache/hamilton/tree/main/plugin_tests
https://github.com/apache/hamilton/tree/main/tests
Please.
…s and plugin_tests directories #1360
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
There was a problem hiding this comment.
you shouldn't add a source header here because there already is one
There was a problem hiding this comment.
You're right.
It's fixed, and I ran a script to check for any duplicate cases. I didn't find anything else besides this one.
ui/sdk/setup.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
ui/backend/setup.py
Outdated
| # /usr/bin/env python | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| """The setup script.""" |
There was a problem hiding this comment.
can we have the license header before this line?
There was a problem hiding this comment.
fixed. added between shebang(can not add before this) and coding comment.
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm - I would still recommend that we do a second pass after this is merged to check for any remaining issues
3 participants
Add Apache license headers to source files.
These changes applied in hamilton, ui, contrib, tests, dev_tools and plugin_tests directories on code files.
Changes
How I tested this
Notes
Checklist