-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19204. VectorIO regression: empty ranges are now rejected #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19204. VectorIO regression: empty ranges are now rejected #6887
Conversation
c65b411
to
3ffa8fb
Compare
- restore old outcome: no-op - test this - update spec Contributed by Steve Loughran Change-Id: I8a2b8c23f573692bd147de82e98b57d2712b0b16
3ffa8fb
to
ba99be5
Compare
Change-Id: Ia4003caa505d30fb8f21bc4081ddb1246831cc49
🎊 +1 overall
This message was automatically generated. |
Could you please point to the test in Parquet/Spark which is doing this? |
internal sql testing where the query selected none of any of the rows after the push down filtering scanned them. This is a legitimate codepath, just one which didn't get picked up in parquet itself. I'll need to look at those tests there to see if there more we should parameterize on vectorisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
- restore old outcome: no-op - test this - update spec This is a critical fix for vector IO and MUST be cherrypicked to all branches with that feature Contributed by Steve Loughran
…che#6887) - restore old outcome: no-op - test this - update spec This is a critical fix for vector IO and MUST be cherrypicked to all branches with that feature Contributed by Steve Loughran
…che#6887) - restore old outcome: no-op - test this - update spec This is a critical fix for vector IO and MUST be cherrypicked to all branches with that feature Contributed by Steve Loughran
How was this patch tested?
new test case in AbstractContractVectoredReadTest; tested on
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?