-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151
Conversation
Blocked by: #6133 (comment) |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
9373c7c
to
404c08c
Compare
💔 -1 overall
This message was automatically generated. |
This is now blocked by https://issues.apache.org/jira/browse/HADOOP-18916 - commons-io 2.14.0 jar has module-info.class |
#6131 is in trunk now |
@steveloughran I have a backport PR for the module-info classes at #6188 |
404c08c
to
400e2c3
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
javac warning looks strange & unrelated
A part of this PR comes from HADOOP-18301.
Test failures look unrelated, I will run them once locally before merging this
💔 -1 overall
This message was automatically generated. |
Can you check the failures and javac warnings, on trunk everything was green.. |
… by PJ Fanning Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…ontributed by PJ Fanning Co-authored-by: Ayush Saxena <ayushsaxena@apache.org>
400e2c3
to
2561508
Compare
Unless they have any user facing changes, I think we are safe, but if something change at the end user side, then maybe we can explore using the deprecated ones only |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There are some broken tests that need review.
possibly also hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery |
looks like the broken tests are already broken - see this unrelated PR but similar test failures there too |
backport #6133